Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering the email template subject in leave notification (backport #2027) #2046

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 6, 2024

fixes: https://discuss.frappe.io/t/how-can-i-put-name-in-subject-in-email-templatee/129550?u=ncp

Before:

image

After:

  • fixed for Leave Approval Notification and Leave Status Notification

image


This is an automatic backport of pull request #2027 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from ruchamahabal as a code owner August 6, 2024 07:57
@ruchamahabal ruchamahabal merged commit 1e576fc into version-14-hotfix Aug 6, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-2027 branch August 6, 2024 08:21
frappe-pr-bot pushed a commit that referenced this pull request Aug 7, 2024
## [14.29.3](v14.29.2...v14.29.3) (2024-08-07)

### Bug Fixes

* concurrency issue leading to duplicate attendance insertion ([#2041](#2041)) ([#2042](#2042)) ([3411d7a](3411d7a))
* filter and bold issue in Salary Payments Based On Payment Mode (backport [#2025](#2025)) ([#2048](#2048)) ([0913976](0913976))
* filter in reports (backport [#1987](#1987)) ([#2044](#2044)) ([adeb482](adeb482))
* query in Provident Fund and Professional Tax Deductions reports (backport [#2026](#2026)) ([#2033](#2033)) ([617de87](617de87))
* rendering the email template subject in leave notification (backport [#2027](#2027)) ([#2046](#2046)) ([1e576fc](1e576fc))
* wrong compute of CTC on salary slip, if employee relieving date before end of payroll period. (backport [#1779](#1779)) ([#2053](#2053)) ([f8837e4](f8837e4))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.29.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants