fix(Expense Claim): get_taxes condition (backport #2077)

[mergify]

Issue

After adding a few rows in the expenses table, new ones randomly become uneditable.

Investigation

It seems to occur because of the following code, which is executed every time the sanctioned amount in an expense is updated. Not entirely sure why, but turns out that making any server side call causes this to happen.

	get_taxes: function (frm) {
		if (frm.doc.taxes) {
			frappe.call({
				method: "calculate_taxes",
				doc: frm.doc,
				callback: () => {
					refresh_field("taxes");
					frm.trigger("update_employee_advance_claimed_amount");
				},
			});
		}
	},

Temporary Solution

The get_taxes function is meant to run only if there are taxes added in the expense claim document. However, an empty array being a truthy value, frm.doc.taxes in if (frm.doc.taxes) always returns true and this call is made for every expense.

Fixing this condition, at the very least, prevents this issue from occurring for most users (who I'm guessing add their taxes after their expenses). However, a more universal fix, involving business logic refactoring, may be in order.

---

This is an automatic backport of pull request #2077 done by Mergify.

[frappe-pr-bot]

🎉 This issue has been resolved in version 14.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀