fix: query for payroll cost centers should only consider the latest salary assignment #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
fix-payroll-cost-center
branch
from
de0ded9
to
038c2d8
Compare
ruchamahabal
force-pushed
the
fix-payroll-cost-center
branch
from
f1bb1af
to
c036831
Compare
ruchamahabal
added
backport version-14-hotfix
backport version-15-hotfix
and removed
backport version-14-hotfix
labels
ruchamahabal
added a commit
that referenced
this pull request
Aug 29, 2024
…2133 fix: query for payroll cost centers should only consider the latest salary assignment (backport #2133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to replicate
Fix
Rectify the query for fetching payroll cost centers to only consider the latest salary structure assignment. Currently it fetches child table records of all assignments with matching structure
After:
Regression from: 2793f96
Support ticket: https://support.frappe.io/helpdesk/tickets/20032
A mismatch in Salary Register & Profit & Loss Accounts led to this discovery