fix(Payroll): skip dependent component update if no formula is set #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
added a commit
that referenced
this pull request
Sep 4, 2024
…ackport #2152) (#2153) (cherry picked from commit eaa8d3d) Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
## [15.28.2](v15.28.1...v15.28.2) (2024-09-04) ### Bug Fixes * **Employee Checkin:** set the form as dirty on fetching geolocation (backport [#2157](#2157)) ([#2158](#2158)) ([3598ae9](3598ae9)) * **Payroll:** calculate loan repayment amount based on payroll end date instead of posting date (backport [#2154](#2154)) ([#2156](#2156)) ([020344d](020344d)) * **Payroll:** skip dependent component update if no formula is set (backport [#2152](#2152)) ([#2153](#2153)) ([190959f](190959f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in continuation to #2147, #2138 🫠
for the change #2088
If a row has Amount based on formula enabled, but formula is not set, it fails because compile expects a string:
Skip dependent component update if no formula is set