fix: Accomodate common_filters=None in Bank Reco API
#2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruthra-kumar Hey can you add a backport v15 label? I don't have access to labels in this repository |
|
Haven't tested this. Trusting the direct merge 🙈 |
ruchamahabal
added a commit
that referenced
this pull request
Sep 24, 2024
…2224 fix: Accomodate `common_filters=None` in Bank Reco API (backport #2224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1510 (comment), alyf-de/banking#108
get_matching_queriesandget_ec_matching_querydefault tocommon_filters=Nonebut do not handle the case where it is NoneINSql Operator does not accept empty lists. Ifmode_of_paymentsreturns an empty list, the query breaks