refactor(Salary Structure Assignment): opening balances setup warning + section visibility #2309
+66
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in assignment - this setting just toggles visibility of the opening earnings till date & tax deducted till date, but if its disabled & amounts are set, these amounts are still considered in payroll - seems like an overkill to just control visibility
ruchamahabal
force-pushed
the
fix-opening-earnings-section-visibility
branch
from
4ff9af2
to
574176d
Compare
ruchamahabal
force-pushed
the
fix-opening-earnings-section-visibility
branch
from
574176d
to
df980ce
Compare
ruchamahabal
changed the title
ruchamahabal
added a commit
that referenced
this pull request
Oct 18, 2024
…2309 refactor(Salary Structure Assignment): opening balances setup warning + section visibility (backport #2309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified overengineered setup for setting opening balances in salary structure assignments:
Remove a checkbox from Payroll Settings. This setting just toggles the visibility of the opening earnings till date & tax deducted till date, but if it's disabled & amounts are set, these amounts are still considered in the payroll. Seems like an overkill for just controlling visibility
Relabelled opening balances section
Simplified logic for toggling & warning about opening balances. Too much back and forth between functions, buggy and typos in functions
Closes #1853