Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Report): Employee working on a holiday #977

Merged
merged 6 commits into from
Oct 14, 2024
Merged

refactor(Report): Employee working on a holiday #977

merged 6 commits into from
Oct 14, 2024

Conversation

niraj2477
Copy link
Contributor

fixes: #975

TODO

  • Add tests

@niraj2477
Copy link
Contributor Author

@ruchamahabal Any updates on this PR?

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (08411c8) 72.54% compared to head (51bb799) 72.52%.
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #977      +/-   ##
===========================================
- Coverage    72.54%   72.52%   -0.02%     
===========================================
  Files          200      200              
  Lines        10916    10919       +3     
===========================================
  Hits          7919     7919              
- Misses        2997     3000       +3
Files Coverage Δ
...ing_on_a_holiday/employees_working_on_a_holiday.py 0.00% <0.00%> (ø)

@krantheman krantheman self-assigned this Oct 14, 2024
@krantheman
Copy link
Member

Merging now; will add tests after fixing CI 💀

@krantheman krantheman merged commit 7f6d346 into frappe:develop Oct 14, 2024
7 checks passed
This was referenced Oct 14, 2024
Merged
Merged
krantheman added a commit that referenced this pull request Oct 14, 2024
@krantheman
Merge pull request #2280 from frappe/mergify/bp/version-15-hotfix/pr-977
5777091 
refactor(Report): Employee working on a holiday (backport #977)
krantheman added a commit that referenced this pull request Oct 14, 2024
@krantheman
Merge pull request #2279 from frappe/mergify/bp/version-14-hotfix/pr-977
8b2021e 
refactor(Report): Employee working on a holiday (backport #977)
@krantheman krantheman mentioned this pull request Oct 18, 2024
Merged
This was referenced Oct 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal ruchamahabal is a code owner

Assignees

@krantheman krantheman

Labels
backport version-14-hotfix backport version-15-hotfix needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] Employees working on a holiday report
3 participants
@niraj2477 @codecov-commenter @krantheman