Implement filter by ids #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freakboy3742 bump |
freakboy3742
requested changes
Aug 26, 2020
There was a problem hiding this comment.
I feel like we can provide a much more Pythonic API here. The Xero API may expose "IDs" as a comma separated string, but that doesn't mean PyXero's API needs to be the same. Otherwise, there's no benefit over using raw.
I'd expect the public API for IDs to be a list of strings, concatenated internally to a single string.
|
@freakboy3742 done |
freakboy3742
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by: #267
Xero offers a fast way to select multiple invoices by using the
IDsparam. This has been added to the_filtermethod.https://developer.xero.com/documentation/api/requests-and-responses
Usage: