Add config to pass on token scope-change warnings #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we call `requests_oauthlib.OAuth2Session#fetch_token` which * [calls `oauthlib.oauth2.WebApplicationClient#parse_request_body_response`](https://github.com/requests/requests-oauthlib/blob/3a2a852e33c691c7e793300ce366a01b6e4b3848/requests_oauthlib/oauth2_session.py#L388) which * is actually `oauthlib.oauth2.rfc6749.clients.Client#parse_request_body_response` which * [calls `oauthlib.oauth2.rfc6749.parameters.parse_token_response`](https://github.com/oauthlib/oauthlib/blob/6569ec3c062be7268f4a17f5a371aa29f1bcfa4a/oauthlib/oauth2/rfc6749/clients/base.py#L427) which * [emits a `Warning` on changed scopes](oauthlib/oauthlib@ca4811b#diff-27d6ecb53c0926bcd8cc87f98cf661d5e2936cd48b04f57cdfdb63cd3b23ab38R400-R406), complete with the parsed token * sets `self.token` * [calls `self.populate_token_attributes`](https://github.com/oauthlib/oauthlib/blob/6569ec3c062be7268f4a17f5a371aa29f1bcfa4a/oauthlib/oauth2/rfc6749/clients/base.py#L428) * sets `self.token` which * [sets the WebApplicationClient's token again, and calls its `populate_token_attributes` again](https://github.com/requests/requests-oauthlib/blob/3a2a852e33c691c7e793300ce366a01b6e4b3848/requests_oauthlib/oauth2_session.py#L142-L145) * returns `self.token` Since we get exactly the same token in the warning, and the [original commit's message](oauthlib/oauthlib@ca4811b) suggests the warning is optional, it seems as though we can just do `session.token = e.token` (whose setter calls the necessary follow-on logic) and continue as usual.
freakboy3742
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a more-explicit fix for #287
requests_oauthlib.OAuth2Session#fetch_tokenwhichoauthlib.oauth2.WebApplicationClient#parse_request_body_responsewhichoauthlib.oauth2.rfc6749.clients.Client#parse_request_body_responsewhichoauthlib.oauth2.rfc6749.parameters.parse_token_responsewhichWarningon changed scopes, complete with the parsed tokenself.token* callsself.populate_token_attributesself.tokenwhichpopulate_token_attributesagainself.tokenSince we get exactly the same token in the warning, and the original commit's message suggests the warning is optional, it seems as though we can just do
session.token = e.token(whose setter calls the necessary follow-on logic) and continue as usual.