Updates to schema.jl and runtests.jl #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most important change is that we now start-up a local webserver in the tests, instead of passing some initial `id_map`. As far as I can tell, `idmap0` was undocumented and only used by the tests to work-around the lack of a webserver.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=========================================
+ Coverage 94.14% 99.2% +5.06%
=========================================
Files 3 3
Lines 256 253 -3
=========================================
+ Hits 241 251 +10
+ Misses 15 2 -13
Continue to review full report at Codecov.
|
odow
changed the title
|
@fredo-dedup any thoughts on removing the |
|
Unless there are objections, I will merge this Monday, April 20. |
jaakkor2
reviewed
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly working my way through schema and runtests to educate myself about what this code does. The changes are mainly style and simplifications.
Most important change is that we now start-up a local webserver in the tests, instead of passing some initial
idmap0(which is now removed). @fredo-dedup as far as I can tell,idmap0was undocumented and only used by the tests to work-around the lack of a webserver?I renamed
parentFileDirectorytoparent_dirfor a little more consistency.