-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to schema.jl and runtests.jl #13
Conversation
Most important change is that we now start-up a local webserver in the tests, instead of passing some initial `id_map`. As far as I can tell, `idmap0` was undocumented and only used by the tests to work-around the lack of a webserver.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=========================================
+ Coverage 94.14% 99.2% +5.06%
=========================================
Files 3 3
Lines 256 253 -3
=========================================
+ Hits 241 251 +10
+ Misses 15 2 -13
Continue to review full report at Codecov.
|
@fredo-dedup any thoughts on removing the |
Unless there are objections, I will merge this Monday, April 20. |
Slowly working my way through schema and runtests to educate myself about what this code does. The changes are mainly style and simplifications.
Most important change is that we now start-up a local webserver in the tests, instead of passing some initial
idmap0
(which is now removed). @fredo-dedup as far as I can tell,idmap0
was undocumented and only used by the tests to work-around the lack of a webserver?I renamed
parentFileDirectory
toparent_dir
for a little more consistency.