Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable parameter insertAfter and insertBefore overriden by default #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pp-surbhigupta
Copy link

When integrating the Plugin, I faced an issue that my content was not getting replaced at the position mentioned in the configuration

$('#scrollableList').endlessScroll({
fireOnce: false,
inflowPixels: 1,
insertAfter: '#scrollableList div:last',
insertBefore: '#scrollableList div:last',
loader: ''
});

insertAfter and insertBefore were overriden in the function EndlessScroll.prototype.setInsertPositionsWhenNecessary since we are using default to check if insertAfter and insertBefore are provided. We should be checking for options.insertAfter and options.insertBefor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant