-
-
Notifications
You must be signed in to change notification settings - Fork 359
add globalstyles and minimal css reset #148
add globalstyles and minimal css reset #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🎉, just minor suggestions.
We should also correct properties like the inline-block
display not defined in IE6/7/8/9. Thoughts?
Also, address the font-family inconsistency between 'textarea' and other form elements
iframe, | ||
img, | ||
object, | ||
video { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, add the following tags:
article,
aside,
details,
figcaption,
figure,
footer,
header,
hgroup,
nav,
section,
summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by adding these elements? Do they need some reset in some form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about IE6/7/8/9. I don't think we should bother supporting those browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a browser support conversation on #144.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by adding these elements? Do they need some reset in some form?
Yes, I meant adding reset rules for the mentioned tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not necessary
Co-Authored-By: Vaibhav Singh <[email protected]>
@ThomasRoest We are going to use Material-UI so we don't need to add reset styles explicitly. |
I don't know if I am missing anything, but have we reached the conclusion that which UI framework we will use? |
@vaibhavsingh97 Quincy finalized it: #47 (comment) |
Awesome!! thanks @vkWeb 👍 |
Update README.md
).master
branch of Chapter.Adds a globalstyles component with a minimal reset. Any other ideas/improvements welcome ofcourse!