Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Add locations CRUD api #340

Merged
merged 7 commits into from
Feb 19, 2020
Merged

Conversation

Zeko369
Copy link
Member

@Zeko369 Zeko369 commented Feb 15, 2020

Add API for creating/reading/updating/deleting locations

  • Add filter by params
  • Add address to location modal
  • Update swagger docs

@Zeko369 Zeko369 changed the title [WIP] Add locations CRUD api Add locations CRUD api Feb 16, 2020
@Zeko369 Zeko369 mentioned this pull request Feb 16, 2020
Copy link
Contributor

@timmyichen timmyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some requested changes re protecting routes and using express-response-errors where possible

server/controllers/locationController.ts Outdated Show resolved Hide resolved
server/controllers/locationController.ts Outdated Show resolved Hide resolved
server/controllers/locationController.ts Show resolved Hide resolved
server/controllers/locationController.ts Show resolved Hide resolved
server/controllers/locationController.ts Outdated Show resolved Hide resolved
server/controllers/locationController.ts Outdated Show resolved Hide resolved
server/controllers/locationController.ts Outdated Show resolved Hide resolved
server/controllers/locationController.ts Outdated Show resolved Hide resolved
server/controllers/locationController.ts Outdated Show resolved Hide resolved
server/controllers/locationController.ts Outdated Show resolved Hide resolved
@Zeko369 Zeko369 merged commit 13aaeb2 into freeCodeCamp:master Feb 19, 2020
@Zeko369 Zeko369 deleted the feature/locationsCRUD branch February 19, 2020 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants