Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Code Template For Word Blanks #15142

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Cleanup Code Template For Word Blanks #15142

merged 1 commit into from
Jun 1, 2017

Conversation

jonathanihm
Copy link
Contributor

Fix for #15137, placement of results variable moved inside comments to be more helpful and intuitive for newcomers.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 31, 2017
@JBallin
Copy link

JBallin commented May 31, 2017

I propose to reject and close both this PR #15142 and the corresponding Issue #15137.

I've provided my reasons why in the issue.

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✨ LGTM. ✨ ✨

Thanks @jonathanihm !

And congrats on your first contribution freeCodeCamp! ✨ ✨ ✨

@raisedadead raisedadead merged commit a33ebd3 into freeCodeCamp:staging Jun 1, 2017
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 1, 2017
@raisedadead
Copy link
Member

@jonathanihm just a tip, it would be great if you fill up the PR template which is a just checklist for moderators to know if the contributor got everything verified.

Thanks, and please keep contributing.

@jonathanihm
Copy link
Contributor Author

Thanks @raisedadead,

I will do better on future PRs! I wil do what I can :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants