This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
Fix/converts dates to short format - fixes #299 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspaine
reviewed
Nov 12, 2017
There was a problem hiding this comment.
Thanks! I added a small suggestion.
Also not sure what's going on with the commits in this PR? The readme change in the first commit was made on the master branch, so really not sure why it's here.
Wait until this is merged, then, if you can't figure out how to fix it, you might have to delete your fork and re-create it.
| @@ -259,6 +260,15 @@ function exists(thing) { | |||
| return thing | |||
| } | |||
|
|
|||
| function isValid(date) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used Moment.JS to convert dates on the packing list to a more readable, short format (MM/DD/YYY).
However, if anyone else is still working on this, please feel free to disregard and drop. I just wanted to take a crack at it and see if I could get it working.