This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
Prevent deleting customers with packages #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspaine
reviewed
Nov 23, 2017
server/controllers/customer.js
Outdated
| await User.findByIdAndRemove(id) | ||
| await Customer.findByIdAndRemove(id) | ||
| // Check to see if the customer is associated with any packages | ||
| const packages = await Package.find({customer: id}) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Looks good, thought you were going for the |
|
Here it is using count() In the future I still would like to have either a deleted or retired flag for the customer to indicate the customer is no longer with the food bank but to keep its data for record keeping. But for now this prevents packages from referencing a customer that no longer exists. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #275