Automate maintainer-approval flag & Improve cat/port detection #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: extensions/BFBSD/lib/Helpers.pm ==> 1) added some constant values 1-a)from AA module to here for using in other modules [like FBSDAttachments:D] 1-b)a value for listing all categories (in order to be used in regexes) 2) editted regexes to find "category/port" string in better way* new file: extensions/FBSDAttachments/Config.pm ==> config file for "FBSDAttachments" module new file: extensions/FBSDAttachments/Extension.pm ==> FBSDAttachments module itself :D modified: extensions/FBSDAutoAssign/Extension.pm ==> changed regexes to find "category/port" string in better way* * if we assume we know all category names we can change regex in a way to search for strings in form of (category name from our valid pool)/name of port in way of regex :D
koobs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified: extensions/BFBSD/lib/Helpers.pm
new file: extensions/FBSDAttachments/Config.pm
new file: extensions/FBSDAttachments/Extension.pm
modified: extensions/FBSDAutoAssign/Extension.pm
port names are strings in type of words(alphanumeric and _) and + and - and . but we know end of port name isn't '.' :)
This PR addresses: