Keepalive #17
Merged
Keepalive #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soycode PTAL |
Closed
| @@ -16,25 +16,21 @@ | |||
| * @param {WebSocket} webSocket Alternative webSocket implementation for tests | |||
| **/ | |||
| var DEBUGLOGGING = false; | |||
| var WS_URL = 'ws://localhost:8082/route/'; | |||
| //var WS_URL = 'wss://data.radiatus.io/route/'; | |||
There was a problem hiding this comment.
It looks like hardcoding it here changes the logic a bit, i.e. makes it so WS_URL is always localhost rather than being localhost when DEBUG is true and radiatus.io otherwise. If that's intentional I'm okay with that, but it may still be nice to have some sort of flag to select or pass in a custom WS host.
There was a problem hiding this comment.
Good point. The code we had before was defacto hardcoded, because the DEBUG variable is never set or passed in anywhere. So this was just to clear up the code
We do want some way to configure the endpoint (e.g.dist vs testing) and my issue here will track that
#16
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Note: browserify 9.0.5 seems to be broken, so I'm forcing a ceiling in our dependencies