-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action for Tor update check #221
Conversation
f01f10c
to
227d566
Compare
fb9702c
to
3c61035
Compare
I think this is ready for a review pass. What I've tested:
A new Using both tokens in the same job seems to work fine, since I've not tested the actual I'm happy to help with any additional pre-merge testing. freedomofpress/securedrop-builder#493 removes the corresponding CircleCI logic in |
a9d27ad
to
383d3cc
Compare
We're using the exissting PUSH_TOKEN to push packages, and a newly created ISSUES_TOKEN to open issues in the `securedrop` repo. The `new-tor-issue` script and parts of the job code were imported from the `securedrop-builder` repo and authored by Kunal Mehta, see freedomofpress/securedrop-builder#408
383d3cc
to
d364a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, I think the testing you've done is sufficient to land this, if there's an issue with permissions or whatever we can fix it iteratively.
aa77f8d
to
19a8686
Compare
19a8686
to
09c5034
Compare
09c5034
to
81fbba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks :D
Status
Ready for review
Refs freedomofpress/securedrop-builder#482
The
new-tor-issue
script and parts of the job code were imported from thesecuredrop-builder
repo and authored by Kunal Mehta, see freedomofpress/securedrop-builder#408 and freedomofpress/securedrop-builder#287Description of changes
Migrate logic for checking for and applying Tor updates to GitHub Actions