Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dh-virtualenv causes build path to be captured #430

Closed
legoktm opened this issue Mar 17, 2023 · 1 comment
Closed

dh-virtualenv causes build path to be captured #430

legoktm opened this issue Mar 17, 2023 · 1 comment

Comments

@legoktm
Copy link
Member

legoktm commented Mar 17, 2023

Was trying to reproduce securedrop-client and hit:

│ │ ├── ./opt/venvs/securedrop-client/bin/activate.xsh
│ │ │ @@ -24,15 +24,15 @@
│ │ │          del aliases["deactivate"]
│ │ │  
│ │ │  
│ │ │  # unset irrelevant variables
│ │ │  _deactivate(["nondestructive"])
│ │ │  aliases["deactivate"] = _deactivate
│ │ │  
│ │ │ -$VIRTUAL_ENV = r"/home/user/securedrop-builder/build/debbuild/packaging/securedrop-client/debian/securedrop-client/opt/venvs/securedrop-client"
│ │ │ +$VIRTUAL_ENV = r"/src/build/debbuild/packaging/securedrop-client/debian/securedrop-client/opt/venvs/securedrop-client"
│ │ │  
│ │ │  $_OLD_VIRTUAL_PATH = $PATH
│ │ │  $PATH = $PATH[:]
│ │ │  $PATH.add($VIRTUAL_ENV + _get_sep() + "bin", front=True, replace=True)
│ │ │  
│ │ │  if ${...}.get("PYTHONHOME", ""):
│ │ │      # unset PYTHONHOME if set

dh-virtualenv is supposed to patch out the build path, but it misses this file. I had previously pointed this out at freedomofpress/securedrop#6538 (comment) but filing it as an independent issue since it is affecting reproducibility.

@legoktm
Copy link
Member Author

legoktm commented Feb 6, 2024

dh-virtualenv was dropped in freedomofpress/securedrop-client#1741.

@legoktm legoktm closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant