Add and refactor Debianization #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
force-pushed
the
better-debian
branch
from
8613d65
to
eaeca6d
Compare
legoktm
force-pushed
the
better-debian
branch
9 times, most recently
from
302a37a
to
00e114a
Compare
This copies in all the packaging files from securedrop-builder plus the keyring and workstation-config components and refactors them to use a single source package for the build, like securedrop server. Building all workstation Debian packages now has one entrypoint, `./scripts/build-debs.sh` (a make target could be added in the future); all packages use the same version. As part of the migration, dh-virtualenv was replaced with `./debian/setup-venv.sh` that invokes virtualenv and sed directly to implement the same functionality. Package building is now done by GitHub Actions in a singular job, having this build and push nightlies will be done in a future commit.
7 tasks
securedrop-client:securedrop-client debdiffOnly major difference is due to the merge of the SDK into the client as per #1746. securedrop-exportdebdiffsecuredrop-keyring (0.2.1 vs new 0.9.0)debdiff and diffoscope all good, no meaningful difference. securedrop-logdebdiff and diffoscope all good, no meaningful difference. securedrop-proxydebdiff resultssecuredrop-workstation-configNo significant difference. securedrop-workstation-viewerNo significant difference. |
zenmonkeykstop
previously approved these changes
Jan 18, 2024
zenmonkeykstop
approved these changes
Jan 18, 2024
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready to review
Description
This copies in all the packaging files from securedrop-builder plus the keyring and workstation-config components and refactors them to use a single source package for the build, like securedrop server.
Building all workstation Debian packages now has one entrypoint,
./scripts/build-debs.sh(a make target could be added in the future); all packages use the same version.As part of the migration, dh-virtualenv was replaced with
./debian/setup-venv.shthat invokes virtualenv and sed directly to implement the same functionality.Package building is now done by GitHub Actions in a singular job, having this build and push nightlies will be done in a future commit.
Test plan
./scripts/build-debs.sh, see bullseye debs are in the build/ directoryDEBIAN_VERSION=bookworm ./scripts/build-debs.shand see that it builds bookworm debs.