Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI job to make easier to spot linting issues #1262

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Add CI job to make easier to spot linting issues #1262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@ common-steps:
export PYTHONPATH=$PYTHONPATH:. # so alembic can get to Base metadata
make check --keep-going

- &check_python_dependencies_for_vulns
- &run_lint
run:
name: Check Python dependencies for known vulnerabilities
name: Run lint, then static analysis on source code to find security issues
command: |
set -e
source .venv/bin/activate
make safety
make check-black check-isort lint bandit

- &run_static_analysis
- &check_python_dependencies_for_vulns
run:
name: Run static analysis on source code to find security issues
name: Check Python dependencies for known vulnerabilities
command: |
set -e
source .venv/bin/activate
make bandit
make safety

- &install_packaging_dependencies
run:
Expand Down Expand Up @@ -89,8 +89,8 @@ jobs:
- checkout
- run: sudo apt-get install -y sqlite3 libqt5x11extras5
- *run_tests
- *run_lint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can always switch this later to run linters before tests if it causes headache. you've already mentioned the tradeoff here, so let's see how it goes as is!

- *check_python_dependencies_for_vulns
- *run_static_analysis

workflows:
version: 2
Expand Down