Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update especially Pillow and pip-tools #1433

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Conversation

cfm
Copy link
Member

@cfm cfm commented Feb 25, 2022

Description

Updates dependencies primarily to address Safety warnings for CVEs 2022-22817 and 2022-24303 in Pillow, used only in the development environment.

Other incidental updates:

  1. pip-tools for pip-compile fails with pip==22.0 jazzband/pip-tools#1558; and
  2. Black, which required changes from make black to pass CI.

Test Plan

  • CI passes.
  • The Client runs in a fresh virtualenv, e.g.:
    $ rm -rf .venv  # skip in disposable VM
    $ make venv
    $ source .venv/bin/activate
    $ ./run.sh

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit c1fde99 into main Mar 8, 2022
@sssoleileraaa sssoleileraaa deleted the pillow-9.0.1 branch March 8, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants