Show full timestamp of last source activity #1628
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1563
Building on #1626 this change modifies securedrop-client so that it shows the full timestamp rather than just the date of the last source activity.
Once concern noted elsewhere about this date is that it is not the last updated (as the user would expect) - it's the last source activity time. I've added a tooltip to this effect but I don't think that's sufficient. However, we're already showing the date, adding the time doesn't make it any more 'wrong' so this feels like a helpful improvement.
I've got two other date/time related PRs stacked up:
With that in mind, I think we could merge this to our fork potentially and bundle with our next release, whilst separately proposing changes to the main freedomofpress repo once those other changes have been discussed/approved.
Test Plan
I've tested this on qubes and macos
Qubes:
Macos:
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
main
and confirmed that the migration is self-contained and applies cleanlymain
and would like the reviewer to do so