Centralize CI for bandit and safety #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these projects can be run centrally across all components and don't need to be installed and configured separately four times. This also identifies and fixes that bandit wasn't being run on export (though the issue it flagged was a false positive). Refs #1773.
legoktm
force-pushed
the
centralized-lint
branch
from
0f1bedf
to
9792fa7
Compare
zenmonkeykstop
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Both of these projects can be run centrally across all components and don't need to be installed and configured separately four times.
This also identifies and fixes that bandit wasn't being run on export (though the issue it flagged was a false positive).
Refs #1773.
Test Plan
make lint, see it pass. Remove one of the# nosectags, see that it fails.make safety, see it pass. Remove one of the--ignoreentries in the Makefile, see that it fails.banditandsafetyin the individual component folders, should get no hits outside of changelogs.