Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Jinja2 3.1.3 for Safety 64227 #1832

Merged
merged 1 commit into from
Feb 15, 2024
Merged

chore: update to Jinja2 3.1.3 for Safety 64227 #1832

merged 1 commit into from
Feb 15, 2024

Conversation

cfm
Copy link
Member

@cfm cfm commented Feb 13, 2024

Status

Ready for review

Description

Addresses Safety 64227, pinned to v3.1.3 because that's what's diff-reviewed for production in freedomofpress/securedrop#7107.

@cfm cfm requested a review from a team as a code owner February 13, 2024 19:31
@rocodes rocodes self-assigned this Feb 13, 2024
@rocodes
Copy link
Contributor

rocodes commented Feb 13, 2024

@cfm I just restarted CI after merging freedomofpress/securedrop-builder#492, but I would hope/expect it will fail without an update tobuild-requirements.txt. Mind throwing that in as well?

@cfm
Copy link
Member Author

cfm commented Feb 14, 2024

Oops; thanks, @rocodes. I'd thought I was missing a loop-closing step somewhere. Amended in 6d70de5.

@cfm
Copy link
Member Author

cfm commented Feb 15, 2024

Rebased to resolve a conflict in client/poetry.lock due to python-poetry/poetry#496, which will be worth keeping in mind.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this landed then to avoid future conflicts :)

@legoktm legoktm merged commit 9b690b7 into main Feb 15, 2024
50 checks passed
@legoktm legoktm deleted the safety-64227 branch February 15, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants