Support printing images directly based on mimetypes cups supports #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocodes
force-pushed
the
support-direct-print-images
branch
from
10f52f6
to
9f28a72
Compare
legoktm
changed the title
legoktm
changed the title
legoktm
reviewed
Aug 23, 2024
|
Good catches - I will remove them |
rocodes
force-pushed
the
support-direct-print-images
branch
from
9f28a72
to
7008d33
Compare
…a more accurate term; an unknown mimetype will raise ERROR_MIMETYPE_DISCOVERY.
rocodes
force-pushed
the
support-direct-print-images
branch
from
7008d33
to
50b40cd
Compare
legoktm
approved these changes
Aug 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description
Fixes issue with printing images introduced in #2166. Libreoffice supports embedding images and printing them from within LibreOffice, but because many image types aren't in their .desktop file(s) supported MimeTypes, they aren't candidates for pdf conversion. Based on the list of supported types in
/usr/share/cups/mime, add direct printing support for many image mimetypes.Also renames ERROR_MIMETYPE_UNKNOWN to ERROR_MIMETYPE_UNSUPPORTED, which is more accurate, and raise ERROR_MIMETYPE_DISCOVERY (instead of UNKNOWN/UNSUPPORTED) if an error is encountered with parsing mimetypes.
Test Plan
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration is self-contained and applies cleanlymainand would like the reviewer to do so