Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have make build-debs print tag signature, if any #2205

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Have make build-debs print tag signature, if any #2205

merged 1 commit into from
Sep 5, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Sep 4, 2024

Status

Ready for review

Description

If HEAD points to a tag, then run it through git tag -v to print the tag's signature instead of just the commit's.

Test Plan

  • Run the git --no-pager tag -v $(git tag --points-at HEAD) command against a commit that has a tag (i.e. the release/0.13.2 branch) and one that doesn't (this PR)

@legoktm legoktm requested a review from a team as a code owner September 4, 2024 21:55
If HEAD points to a tag, then run it through `git tag -v` to print
the tag's signature instead of just the commit's.
Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Plan

  • Run the git --no-pager tag -v $(git tag --points-at HEAD) command against a commit that has a tag (i.e. the release/0.13.2 branch) and one that doesn't (this PR)

@rocodes rocodes merged commit b4d8ebf into main Sep 5, 2024
58 checks passed
@rocodes rocodes deleted the tag-sig branch September 5, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants