Fix segfault and update PyQt in dev environment #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the version of Python3-PyQt5 shipped by Debian Buster. Updated pip-tools to 4.2 as 3.1 did not work under Buster.
Presence of a `<` would result in the AutoText [1] to result in improper rendering of the Label, resulting in a segmentation fault (see #628). Setting the format to plaintext not only resolves this issue but also provides defense-in-depth to ensure RichText is not displayed. [1]: https://doc.qt.io/qt-5/qt.html#TextFormat-enum
|
I can't get to the point where I'm seeing the segfault, here's what I did:
|
|
oopsies i did that thing again that i do from time to time where i run hehe no wonder I can't repro :bushes: |
sssoleileraaa
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
make allon branch https://github.com/freedomofpress/securedrop-workstation/tree/345-debian-buster- submit something containing
>character to source interface (e.g:<hello>) - Open source in client
- Observe segfault/client crash
- Create deb of client on this branch
- The client no longer segfaults when opening the source created above
This works and diff lgtm!
|
I created a follow-up issue: #633 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #628 .
Test Plan
This test requires Qubes, as it cannot be reproduced in the dev environment.
make allon branch https://github.com/freedomofpress/securedrop-workstation/tree/345-debian-buster>character to source interface (e.g:<hello>)Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable: