Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring SecureDrop Workstation/Client up to parity with SecureDrop Server in contribution guidelines #191

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

cfm
Copy link
Member

@cfm cfm commented Sep 22, 2024

Status

Work in progress

Description of Changes

@ben-grande points out that our contribution guidelines have much more to say about the Server than the Workstation and Client. This pull request accumulates changes of that status quo.

Testing

Visual review.

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, two minor suggestions. Thanks!

docs/contributing.rst Outdated Show resolved Hide resolved
docs/contributing.rst Outdated Show resolved Hide resolved
@cfm cfm self-assigned this Oct 12, 2024
@cfm cfm force-pushed the more-workstation-contrib-guidelines branch from 1c093ec to 053651e Compare October 15, 2024 22:29
@cfm cfm marked this pull request as ready for review October 15, 2024 22:31
@cfm cfm requested a review from legoktm October 15, 2024 23:50
@cfm
Copy link
Member Author

cfm commented Oct 15, 2024

Thanks, @legoktm. Both addressed in 053651e.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legoktm legoktm added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit f538898 Oct 16, 2024
4 checks passed
@legoktm legoktm deleted the more-workstation-contrib-guidelines branch October 16, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants