Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prep-dom0 target #395

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Fix prep-dom0 target #395

merged 1 commit into from
Jan 7, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Jan 6, 2020

Fixes #394

top.enable was removed in #351 in favor of sd-workstation.top file. top.enable will now be handled by prep-salt target, invoked by prep-dom0.

Test plan

  1. On master:
  1. On this branch:
  • make prep-dom0 completes successfully
  • make test, all tests pass (specifically dom0 tests)

top.enable was removed in #351 in favor of sd-workstation.top file. top.enable will now be handled by prep-salt target, invoked by prep-dom0.
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Approved.

Testing

  • make prep-dom0 completes successfully
  • make test, all tests pass (specifically dom0 tests)

@kushaldas kushaldas merged commit 67c69a4 into master Jan 7, 2020
@legoktm legoktm deleted the 394-fix-prep-dom0 branch May 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make prep-dom0 fails when invoked directly
2 participants