Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update_version.sh #4145

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Update update_version.sh #4145

merged 1 commit into from
Feb 15, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Feb 15, 2019

Status

Ready for review

Description of Changes

Fixes #4144

Testing

You can bump the version correctly using the release management guide, securedrop-app-code deb package name is separated with a + instead of a -

Deployment

Dev env only

use `+` instead of `-` to separate distribution in securedrop-app-code versiob
@redshiftzero redshiftzero self-requested a review February 15, 2019 17:31
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@emkll emkll mentioned this pull request Feb 15, 2019
2 tasks
@redshiftzero redshiftzero merged commit 06c3333 into develop Feb 15, 2019
@redshiftzero redshiftzero deleted the 4144-deb-filename-fix branch February 15, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants