Adds libvirt staging environment for Focal #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This was referenced Sep 10, 2020
|
This is now blocked on #5443 |
12 tasks
added 3 commits
September 14, 2020 15:35
Starting with a naive copy/paste from the libvirt-staging-xenial scenario. Will tweak settings as required to get it to run.
The bare minimum required to get the copy/pasted Xenial libvirt scenario working under Focal. Commiting separately to make the changes a bit easier to inspect.
In order to ease the transition to Focal, let's use different vars for packages depending on platform. When running the Xenial logic against Focal, the kernel removal tasks failed since several of the package names were not found. Also adding a "grsecurity" tag since the grsec story for Focal still needs work, so it's easy to skip now.
conorsch
force-pushed
the
5468-libvirt-staging-focal
branch
from
8edba49
to
21b2369
Compare
Between the version of aptitude on Xenial and that on Focal, empty searches started returning 1, causing `Check whether tor will be upgraded` to fail. Let's ignore the exit code, since what we care about is whether "tor" is in the stdout. We could use `apt list --upgradable`, but that command warns about lack of a stable CLI, and additionally we'd have to munge the output further to inspect it.
conorsch
force-pushed
the
5468-libvirt-staging-focal
branch
from
21b2369
to
d0ddfc5
Compare
Configures a libvirt VM staging environment based on Focal. Far from complete, but it's a start.
1 task
kushaldas
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Towards #5468.
Description of Changes
Early stages of Focal support for staging VMs. It's partial progress—areas not currently working are:
Testing
First, prepare the boxes for libvirt, same as required for Xenial:
Then browse to the Source Interface and interact with the app. Report any problems.
Deployment
Yes, provisioning logic has changed a bit. An attempt was made to alter only Focal-related logic where possible, but in two places in particular Xenial-related logic was changed:
aptitudetasks for deciding whether to marktoras held now uses failed_when=false, for Focal compatibilityChecklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locallyIf you added or updated a code dependency:
Choose one of the following: