Testinfra fixes for dual distro #5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are choosing the Python major.minor (3.8/3.5) version based on Focal or Xenial. We are using `MOLECULE_SCENARIO_NAME` environment variable to identify the distribution version during testinfra run.
|
@kushaldas Can you clarify status of this PR? It's currently sitting in "In Development" but the PR body says "Ready for review". |
|
Can I move these changes into the new PR for testinfra updates? Otherwise it will be big conflict there. |
On a second thought, we should merge this first. As this can be clearly tested. |
zenmonkeykstop
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Towards #5509
focalas distribution value for thetestinfratests.testinfratestsTesting
molecule test -s libvirt-staging-focalnow should have only 6 test failures :)Deployment
Any special considerations for deployment? Consider both:
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locallyIf you added or updated a code dependency:
Choose one of the following: