Pin and verify rustup-init sha256 in builder image #6266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an extra defense, pin the rustup version used and verify the hash of the downloaded rustup-init binary. Previously we were downloading the hash from the same place we were downloading the binary, so it didn't really offer any extra protection besides making sure the download wasn't corrupted (which HTTPS does for us). This does not completely protect us, as rustup-init downloads rustup without verifying signatures, but that will hopefully be fixed soon: <rust-lang/rustup#2028>. This shouldn't add a significant amount of maintenance overhead, as old rustup versions can still be used to download newer Rust versions. Fixes freedomofpress/securedrop-security#70.
zenmonkeykstop
approved these changes
Feb 14, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
As an extra defense, pin the rustup version used and verify the
hash of the downloaded rustup-init binary. Previously we were downloading
the hash from the same place we were downloading the binary, so it didn't
really offer any extra protection besides making sure the download wasn't
corrupted (which HTTPS does for us).
This does not completely protect us, as rustup-init downloads rustup
without verifying signatures, but that will hopefully be fixed
soon: rust-lang/rustup#2028.
This shouldn't add a significant amount of maintenance overhead, as old
rustup versions can still be used to download newer Rust versions.
Fixes https://github.com/freedomofpress/securedrop-security/issues/70.
Testing
Deployment
Any special considerations for deployment? No
Checklist