pylint 2.12 issues #244

stanislavlevin · 2022-02-15T11:12:34Z

Pylint 2.12.2 reports several issues:

consider-using-f-string
redundant-u-string-prefix
use-dict-literal
unspecified-encoding
use-list-literal

- f-strings are not mandatory - format can be more readable - there are 140 spotted issues Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Pylint 2.10 introduced new checker `redundant-u-string-prefix`: > Added redundant-u-string-prefix checker: Emitted when the u prefix is added to a string https://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-10-0 pylint-dev/pylint#4102 Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Pylint 2.10 introduced new checker use-dict-literal: > Added use-dict-literal: Emitted when dict() is called with no arguments instead of using {} https://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-10-0 pylint-dev/pylint#4365 Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Pylint 2.10 introduced new checker unspecified-encoding: > Added unspecified-encoding: Emitted when open() is called without specifying an encoding https://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-10-0 pylint-dev/pylint#3826 https://www.python.org/dev/peps/pep-0597/ Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Pylint 2.10 introduced new checker use-list-literal: > Added use-list-literal: Emitted when list() is called with no arguments instead of using [] https://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pylint-2-10-0 pylint-dev/pylint#4365 Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

https://pylint.pycqa.org/en/latest/user_guide/message-control.html#detecting-useless-disables: > As pylint gets better and false positives are removed, disables that became useless can accumulate and clutter the code. In order to clean them you can enable the useless-suppression warning. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Either Fedora's or PyPI's release of Pylint can break ipa-healthcheck's CI. With this change only maintainers of ipa-healthcheck can decide which version of Pylint the project is compatible with. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

https://pylint.pycqa.org/en/latest/user_guide/message-control.html#detecting-useless-disables: > As pylint gets better and false positives are removed, disables that became useless can accumulate and clutter the code. In order to clean them you can enable the useless-suppression warning. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Either Fedora's or PyPI's release of Pylint can break ipa-healthcheck's CI. With this change only maintainers of ipa-healthcheck can decide which version of Pylint the project is compatible with. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

- f-strings are not mandatory - format can be more readable - there are 140 spotted issues Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Pylint 2.10 introduced new checkers: > Emitted when using dict() to create an empty dictionary instead of the literal {}. The literal is faster as it avoids an additional function call. > Emitted when using list() to create an empty list instead of the literal []. The literal is faster as it avoids an additional function call. Too many unessential changes. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Pylint 2.10 introduced new checker: > It is better to specify an encoding when opening documents. Using the system default implicitly can create problems on other operating systems. See https://www.python.org/dev/peps/pep-0597/ According to that PEP: > open(filename) isn't explicit about which encoding is expected: - If ASCII is assumed, this isn't a bug, but may result in decreased performance on Windows, particularly with non-Latin-1 locale encodings - If UTF-8 is assumed, this may be a bug or a platform-specific script - If the locale encoding is assumed, the behavior is as expected (but could change if future versions of Python modify the default) IPA requires UTF-8 environments. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

https://pylint.pycqa.org/en/latest/user_guide/message-control.html#detecting-useless-disables: > As pylint gets better and false positives are removed, disables that became useless can accumulate and clutter the code. In order to clean them you can enable the useless-suppression warning. This doesn't enforce useless-suppression warnings as errors. The idea is cleanup of these warings on every Pylint's bump. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Either Fedora's or PyPI's release of Pylint can break ipa-healthcheck's CI. With this change only maintainers of ipa-healthcheck can decide which version of Pylint the project is compatible with. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>

Pylint 2.10 introduced new checker `redundant-u-string-prefix`: > Used when we detect a string with a u prefix. These prefixes were necessary in Python 2 to indicate a string was Unicode, but since Python 3.0 strings are Unicode by default. There are ~40 emitted warnings right now. They can be fixed on refactorings without any rush. Fixes: freeipa#244 Signed-off-by: Stanislav Levin <[email protected]>