fix(banners): Add logic to avoid duplicating RECAP banners

CHANGES.md

@@ -15,6 +15,7 @@ Changes:
 Fixes: 
  - Tighten security by verifying the sender's identity in communication between Window objects. This prevents a theoretical attack vector that might, with a lot of care and effort, have been able to send bad data to the RECAP Archive. ([#236](https://github.com/freelawproject/recap/issues/236))
  - Fix logic to handle links from appellate PACER to district PACER ([#222](https://github.com/freelawproject/recap/issues/222))
+ - Fix logic to avoid duplicating RECAP banners ([#318](https://github.com/freelawproject/recap/issues/318))
 
 For developers:
  - Nothing yet

src/content.js

@@ -148,11 +148,7 @@ if (allCaseInput) {
 if (caseNumberInput) {
   // Add listener to the search bar
   caseNumberInput.addEventListener('input', () => {
-    let banners = document.querySelectorAll('.recap-banner');
-    // Remove all HTML elements that the extension inserted
-    banners.forEach((banner) => {
-      banner.remove();
-    });
+    PACER.removeBanners();
   });
 }
 

src/content_delegate.js

@@ -220,6 +220,7 @@ ContentDelegate.prototype.handleDocketQueryUrl = function () {
         );
       } else {
         if (result.results) {
+          PACER.removeBanners()
           const form = document.querySelector('form');
           const div = document.createElement('div');
           div.classList.add('recap-banner');

src/pacer.js

@@ -127,6 +127,12 @@ let PACER = {
     return /iquery.pl/.test(url) && /[\d_-]+[A-Z]+[\d_-]+/.test(url)
   },
 
+  // Remove banners inserted by the extension
+  removeBanners: ()=>{
+    let banners = document.querySelectorAll('.recap-banner')
+    banners.forEach(banner => { banner.remove(); });
+  },
+
   // Returns true if the URL is for the iQuery page.
   isBlankQueryReportUrl: function(url){
     // The URL for the query form used in CM/ECF to search cases is: