Add support for audio file PDFs and alternate transcript receipt format #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ttys0dev
commented
Apr 29, 2023
ttys0dev
force-pushed
the
audio
branch
2 times, most recently
from
7e3f138
to
e4bc000
Compare
ttys0dev
changed the title
ttys0dev
commented
Apr 29, 2023
ttys0dev
force-pushed
the
audio
branch
3 times, most recently
from
77223e0
to
8785d90
Compare
|
Wow, busy weekend. It looks like this one is ready too? |
Yep. |
|
Great. I'm putting it on the top of @ERosendo's backlog to review, but he's on a high priority project right now so he might be a moment until he can come up for air. But we do try to prioritize PRs, so hopefully he can switch to it once his current thing is In Review. |
|
Darn, we should have tried to get this into yesterday's release. @ERosendo can you try to get this some love when you finish your current task, please? |
|
Sure! |
ERosendo
requested changes
Jun 28, 2023
There was a problem hiding this comment.
This looks good. I tested your code by uploading a few audio files from 4:17-cr-03038 and It worked great.
Just one comment.
Thanks!
ERosendo
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244.