Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): Adds a banner and a badge for the PACER class action news #364

Merged
merged 10 commits into from
Apr 2, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Mar 31, 2024

This PR fixes freelawproject/recap#367 by adding a badge to the extension icon in the toolbar and a new banner in the extension popup.

Here's a screenshot of the new banner:

image

Here's a GIF showing how the close icon works:

Screen Recording 2024-03-31 at 6 22 46 PM

I created this PR as a draft because we still need the URL for the 'Learn More' button :).

@ERosendo ERosendo force-pushed the 367-feat-adds-pacer-class-action-badge-and-banner branch from 1b96315 to a6edbcc Compare March 31, 2024 22:06
@ERosendo ERosendo requested a review from mlissner March 31, 2024 22:27
@ERosendo ERosendo marked this pull request as ready for review April 2, 2024 16:54
@ERosendo
Copy link
Contributor Author

ERosendo commented Apr 2, 2024

@mlissner I've applied the changes you requested. Here's a GIF showing how it works after the tweaks:

Screen Recording 2024-04-02 at 1 10 49 PM

Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question for you.

We'll tweak the language once Jenifer and I know what it should be.

src/options.html Outdated Show resolved Hide resolved
@mlissner
Copy link
Member

mlissner commented Apr 2, 2024

Great. Feel free to merge once complete, and then we'll do another PR once the language is ready for Firefox.

@ERosendo ERosendo force-pushed the 367-feat-adds-pacer-class-action-badge-and-banner branch from e0e1ebf to bc6f933 Compare April 2, 2024 23:37
@ERosendo
Copy link
Contributor Author

ERosendo commented Apr 2, 2024

@mlissner the PR requires your approval before merging :).

@mlissner mlissner merged commit 4ad7666 into main Apr 2, 2024
8 checks passed
@mlissner mlissner deleted the 367-feat-adds-pacer-class-action-badge-and-banner branch April 2, 2024 23:43
@ERosendo
Copy link
Contributor Author

ERosendo commented Apr 2, 2024

@mlissner Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add badge, banner, and call to action for PACER class action news
2 participants