Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acms): Adds logic to display the warning about combined PDFs #376

Merged
merged 3 commits into from
May 28, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented May 27, 2024

This PR adds logic to check the number of documents on the download page and display the warning about combined PDFs when there's more than one.

Screen Recording 2024-05-27 at 5 58 33 PM

@ERosendo ERosendo marked this pull request as ready for review May 27, 2024 22:09
@ERosendo ERosendo requested a review from mlissner May 27, 2024 22:09
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see if I can resolve conflicts and then merge...

@mlissner mlissner enabled auto-merge May 28, 2024 23:16
@mlissner mlissner merged commit 9581696 into main May 28, 2024
8 checks passed
@mlissner mlissner deleted the feat-add-combined-pdf-warning-to-acms branch May 28, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants