Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): Refines content_scripts permissions on azure websites #385

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Jul 21, 2024

This PR updates the manifest file to implement a least privilege approach for permissions on Azure Websites. We're replacing the use of include_globs with a more granular approach that explicitly defines every single identified URL combination.

This change addresses concerns about overly broad permissions previously granted by the matches property.

Fixes freelawproject/recap#374

Here are screenshots showcasing the revised permission list. Notably, the option granting access to all Azure Websites sites is no longer included.

image

image

@ERosendo ERosendo added the no changelog Override Check Changelog Action. label Jul 21, 2024
@ERosendo ERosendo removed the no changelog Override Check Changelog Action. label Jul 21, 2024
@ERosendo ERosendo marked this pull request as ready for review July 21, 2024 16:32
@ERosendo ERosendo requested a review from mlissner July 21, 2024 16:32
@mlissner
Copy link
Member

Thank you

@mlissner mlissner merged commit c043547 into main Jul 21, 2024
8 checks passed
@mlissner mlissner deleted the fix-refine-permissions-for-azure-websites branch July 21, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome extension azurewebsites.us permission seems too broad
2 participants