Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spinner): Adds spinner next to the custom button for filer accounts #392

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

ERosendo
Copy link
Contributor

This PR addresses comments from Issue #361 and enhances user experience for file accounts:

  • Implements a visual loading indicator (spinner) next to the custom button for filer accounts, providing feedback during PDF retrieval retries.
  • Updates the styling of the recap-bttn-for-filers class to include a pointer cursor, improving user interaction clarity.

Here are gifs showcasing these visually updated elements in appellate and district courts:

Screen Recording 2024-08-30 at 8 14 00 PM

Screen Recording 2024-08-30 at 8 17 33 PM

@ERosendo ERosendo force-pushed the feat-add-spinner-to-view-and-recap-btn branch from 3cc3429 to 391288e Compare August 31, 2024 00:24
@ERosendo ERosendo marked this pull request as ready for review August 31, 2024 00:27
@ERosendo ERosendo requested a review from mlissner August 31, 2024 00:27
@mlissner mlissner merged commit 26e5f85 into main Aug 31, 2024
8 checks passed
@mlissner mlissner deleted the feat-add-spinner-to-view-and-recap-btn branch August 31, 2024 00:41
@mlissner
Copy link
Member

LGTM. I thought I saw the cursor problem in the appellate courts too. Did you happen to take a look?

Thank you!

@ERosendo
Copy link
Contributor Author

Did you happen to take a look?

@mlissner Yes! This PR also fixes the issue in appellate courts. One of the gifs I've included in the PR description is from the Court of Appeals for the Ninth Circuit. Here's the gif again:

Screen Recording 2024-08-30 at 8 17 33 PM

@mlissner
Copy link
Member

Oh, totally, that's great, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants