Fix for picklesdoc#85 : NullReferenceError when feature was not run

freeman · Dec 19, 2013 · 4284056 · 4284056
1 parent b020b65
commit 4284056
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Pickles/Pickles.Test/WhenParsingNUnitResultsFile.cs b/src/Pickles/Pickles.Test/WhenParsingNUnitResultsFile.cs
@@ -158,5 +158,15 @@ public void ThenCanReadNotFoundScenarioCorrectly()
             result.WasExecuted.ShouldBeFalse();
             result.WasSuccessful.ShouldBeFalse();
         }
+
+        [Test]
+        public void ThenCanReadNotFoundFeatureCorrectly()
+        {
+            var results = ParseResultsFile();
+            var feature = new Feature {Name = "NotInTheFile"};
+            var result = results.GetFeatureResult(feature);
+            result.WasExecuted.ShouldBeFalse();
+            result.WasSuccessful.ShouldBeFalse();
+        }
     }
 }
diff --git a/src/Pickles/Pickles/TestFrameworks/NUnitResults.cs b/src/Pickles/Pickles/TestFrameworks/NUnitResults.cs
@@ -50,6 +50,10 @@ public TestResult GetFeatureResult(Feature feature)
         {
             var featureElement = this.GetFeatureElement(feature);
 
+            if (featureElement == null)
+            {
+                return TestResult.Inconclusive;
+            }
             var results = featureElement.Descendants("test-case")
                 .Select(GetResultFromElement);