A few cleanups following removal of support for Ruby v1.8 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
requested changes
Aug 29, 2022
There was a problem hiding this comment.
Hi @nitishr. Many thanks for submitting this. The first commit looks good to me, but I'm a bit less sure about the 2nd one. I've added some questions inline.
nitishr
force-pushed
the
ruby-v1.8-cleanup
branch
from
dd3bb59
to
c68ad49
Compare
Since at least ruby 1.8.7 (the lowest version I checked with),
- Object#respond_to? accepts either string or symbol interchangeably (since at
least ruby 1.8.7)
- __method_exists__? (from Mocha::ClassMethod) accepts either string or symbol
since the methods it passes the arg to
({public,protected,private}_method_defined?) treat them interchangeably
nitishr
force-pushed
the
ruby-v1.8-cleanup
branch
from
1a627d1
to
93bf966
Compare
floehopper
reviewed
Aug 31, 2022
There was a problem hiding this comment.
I belatedly realised that it is safe to remove the call to to_sym from Assertions#assert_method_visibility, so I've changed the last commit to do that. Since strictly speaking not all these changes were enabled by the dropping of support for Ruby v1.8, I've merged these commit manually rather than grouping them into a merge commit.
|
Merged manually. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in #536