Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby2_keywords to invocations and expectations #559

Closed
wants to merge 1 commit into from

Conversation

wasabigeek
Copy link
Contributor

@wasabigeek wasabigeek commented Sep 25, 2022

Enables ruby2_keywords flagging for invocations and expectations, so they can be used later for strict keyword argument matching. This is sketched out in #544 and #446 (comment).

Gemfile Show resolved Hide resolved
Copy link
Member

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this basically looks good to me. I've asked one question inline. As before could you also add a bit of context to the commit note explaining a bit about what the gem does and why we're adding it so the commit note stands alone.

@wasabigeek
Copy link
Contributor Author

Combined into #554

@wasabigeek wasabigeek closed this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants