Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KDC101 controller #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

roflmaostc
Copy link
Contributor

This basically fixes #14 for my special device.
I only had to change a single value.

@freespace
Copy link
Owner

Hi @roflmaostc ,

Thank you for this PR. 2 comments:

  1. you will note that your previous PR, Fix for loop, that all pos are shown #13, has been merged, and this PR seem to include the same changes again. Can you please rebase your branch such that this PR only includes code to introduce the new KDC 101 controller
  2. the KDC 101 is a controller that be used to control many different stages, all of which have their own settings. As such the controllers are stage-specific. For example you will note that the existing controllers mts50 and lts300 are both linear motion stages, not specific controllers. I suggest you rename the KDC101 class to be specific to the stage you are using instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python goto.py values and get_status.py disagree with real distance
2 participants