-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gluon-core: add outdoor channel support for 5 ghz radios #1329
Conversation
In addition to this, it would be great to have some devices pre-configured to use outdoor channels. Devices such as Nanostation M5, CPE510, UniFi AP AC Mesh (probably impossible atm. due to wrong board detection). |
If we're doing client only on 5 GHz we could aim for other htmodes as well, no? |
Simon Wunderlich's slides on "Dynamic Frequency Selection in 5 GHz mesh networks" Intelligent handling of mesh connections is out of scope for this issue. |
As comments were requested in the gluon developer mumble meeting tonight: I would like to see this merged, as we have a lot of Ubiquity AC Mesh Pro devices here in Münsterland, which are running with original firmware so far and could be flashed with Gluon then. For now we install the rocket m2 for mesh and use a dual band access point at the same place. This could be reduced to one dual band device and by this simplifies setups. Vote fore merge. :) |
looking for more people willing to test now! set also the section description and field labels could need some polishing, please start here: https://md.darmstadt.ccc.de/gluon-outdoor-config-mode |
I tested this for the The global regulatory domain seems to be what's used, the per phy value apparently is not.
UAP-AC-Mesh
WDR4900v1 (didn't find a radar-free channel … weird)
|
The last commit adds an improved channel and chanlist validation: wifi24.channel and wifi5.channel now check against an array of valid channels:
Also chanlist validation implements what hostapd describes to be a valid chanlist:
|
And the language strings for |
This issue was unrelated to this PR. |
Model detection for UAP-AC-M is stuck in the openwrt pull request queue (openwrt/openwrt#767) and OpenWrt 18.5 is supposed to be branched in 3 days. IMO this is the most interesting device for this PR, but the review/merge isn't happening. |
It's merged now. |
There was a talk on the last battlemesh where they said that DFS in ath9k is broken as it has far too many false-positives (maybe it was a lightning talk as it is not on the schedule).
|
"false positives" are better than "no 5G outdoor at all". |
@Adorfer You are right. I misunderstood what the PR does. As it falls back to indoor channels when no radar-free channel was detected, it is safe to merge this and I didn't see that one can define devices for which outdoor channels can be used before. @mweinelt We have a very strong CW radar in our city. It uses channels 116-132. Can you please change the outdoor channel siteconf definition to be a list instead so that one can define e.g. outdoor_chanlist = {'100-112', '136', '140'}, add a siteconf check to make sure that the default channel is always an indoor channel and mention this in the docs? The only problem I still see is when radar was detected once and the node switches to the indoor channel it is unlikely that it ever switches to an outdoor channel again or am I missing something? |
outdoor_chanlist = '100-112 136 140', see #1329 (comment) It shouldn't switch to an indoor channel if that's not in the chanlist. (also I'm Martin, not Markus) |
@mweinelt Oh sorry Martin... Did I get it right the first time that when I activate outdoor channels it does not use the default (indoor) channel anymore? |
When you activate outdoor mode it sets:
That removes the indoor channel from the hostapd configuration As I described in #1329 (comment) I indeed had the situation that a WDR4900v1 didn't find a radar-free channel and therefore didn't set up the radio. I didn't research this any further. I've tried this on ath9k/ath10k/mt76, all seem to be working (to some degree?). |
@blocktrron Merging with LibreMesh is on the plan for more than 3 years now. We've talked about that with the LibreMesh developers on the last BattleMesh and last consent was that after we've successfully modularized the packages to be independent from Batman and Babel integration is fine, we should have a look at how to support BMX7. That AREDN-Mesh wants to have a look at switching to Gluon is new. I have the names of devices in #94 corresponding to vendor device IDs from their firmware and extracted the other power offsets from the UBNT firmware. They want to get rid of their Perl-Scripts and switch to a cleaner solution. Edit: BTW description of Gluon is "a modular framework for creating OpenWrt-based firmwares for wireless mesh nodes" and not "Freifunk firmware build environment" |
"Merging with LibreMesh" is unrealistic, and I don't even consider it desirable, as it will further reduce the diversity in mesh firmware frameworks. We can work together and try to create modules that are usable by both projects, but I don't think either project will disappear. |
@CodeFetch Modularization can be achieved in a later refactoring. |
@NeoRaider Yes, it can be done later. I wasn't clear about that. "Merging" was the wrong word. They'd use Gluon as their base system when it's modular enough and as you say merging efforts of common packet development and system stability, device support patching etc. |
|
||
uci:section('gluon', 'wireless', 'wireless', { | ||
outdoor = platform_info.is_outdoor_device() | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is unexpected that the outdoor mode may be enabled on a sysupgrade. When this is not a fresh configuration (sysconfig.gluon_version
is set), outdoor should always be set to false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 492c22e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rather than doing nothing when sysconfig.gluon_version is set, outdoor should be set to false in this case
- I think it would make sense to have a site.conf option that can force the default to on or off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Wow, I didn't properly read what you wrote earlier, sorry. Fixed in f6b9feb.
- TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package/gluon-web-wifi-config/luasrc/lib/gluon/config-mode/model/admin/wifi-config.lua
Outdated
Show resolved
Hide resolved
#1716 caused a few merge conflicts... |
Add the `wifi5.outdoor_chanlist` site configuration that allows specifying an outdoor channel range that can be switched to for regulatory compliance. Upon enabling the outdoor option the device will - configure the `outdoor_chanlist` on all 5 GHz radios - which may enable DFS/TPC, based on the regulatory domain - disable ibss/mesh on the 5 GHz radio, as DFS *will* break mesh connections - allow for htmode reconfiguration on 5 GHz radios The outdoor option can be toggled from - Advanced Settings - W-LAN - Outdoor Installation The `preserve_channel` flag overrules the outdoor channel selection.
adds a section to the wizard for outdoor capable devices that informs the user of of the regulatory situation and allows a quick toggle of the outdoor mode.
I just looked into the feature after it got merged but it looks like there is a mismatch between what is checked in gluon/package/gluon-core/check_site.lua Line 47 in ddb11dd
... and what is read in
Also the documentation says:
|
Thanks, fixed in ad1a190. |
Hmm, should the site.conf setting really be placed under wifi5? While it doesn't matter for 2.4GHz, other frequency bands that may be added in the future will likely have similar restrictions, so I'd see the outdoor mode more as a global (toplevel) flag. |
@mweinelt Opinions on this? |
Yes, long-term you are correct. Short-term (still several years) we're not going to see another frequency band for outdoor usage, are we? We can certainly change this now, I'm not sure we need to. |
Configuring from Config Mode
Configuring from CLI
Outdoor disabled
Outdoor enabled
TODO