Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-mesh-olsrd: support clientap #2788

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Feb 17, 2023

Note: still need to test changes standalone, but this is more or less the working version from graz, so feel free to review.

All of the patches that are being pulled in are submitted upstream for review. The only thing I expect that might happen during review upstream is that some default-on for plugins get rejected, in which case we have to enable it via gluon.

@github-actions github-actions bot added the 3. topic: package Topic: Gluon Packages label Feb 17, 2023
@mkg20001
Copy link
Member Author

For IPv4 a solution with IPv4 AutoLL addresses was proposed, I'd implement that upstream and then have it patched away downstream, back to fixed addresses. But that will be in another PR, since that'll depend on ddhcpd and other changes.

@AiyionPrime AiyionPrime added 2. status: rfc request for comments 5. needs: testing Testing of the changes is necessary 2. status: waiting-on-review Awaiting review from the assignee but also interested parties. labels Feb 25, 2023
@AiyionPrime AiyionPrime added 0. type: question 2. status: waiting-on-author Waiting on some action from the author and removed 2. status: waiting-on-review Awaiting review from the assignee but also interested parties. labels Apr 19, 2023
@mkg20001 mkg20001 force-pushed the olsr2clientap branch 2 times, most recently from 24908b1 to 62f5f6c Compare June 9, 2023 18:17
@neocturne neocturne self-assigned this Jun 13, 2023
@neocturne neocturne self-requested a review June 13, 2023 19:08
@lemoer
Copy link
Member

lemoer commented Jul 15, 2023

In general, this looks good to me.

About the patches: Is there any progress since you submitted them? When do you expect them to be merged?

@mkg20001
Copy link
Member Author

The patches are all upstream with openwrt 23

@lemoer lemoer merged commit fc7a4a0 into freifunk-gluon:master Jul 15, 2023
35 checks passed
@mkg20001 mkg20001 deleted the olsr2clientap branch July 15, 2023 22:32
@herbetom
Copy link
Contributor

When it comes to backports, it's always good to cherry-pick them with -x to get that (cherry picked from commit ...) comment.
That way, tracking is easier. In addition, it becomes quite obvious that those are backports. Just for the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: question 2. status: rfc request for comments 2. status: waiting-on-author Waiting on some action from the author 3. topic: package Topic: Gluon Packages 5. needs: testing Testing of the changes is necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants