Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release tag CLI #1869

Merged
merged 17 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ jobs:
make tag-release-images RELEASE_IMAGE_TAG=v$RELEASE_IMAGE_VERSION
env:
RELEASE_IMAGE_VERSION: ${{ steps.new-semrel-version.outputs.version }}
- name: Re-tag CLI service image with release version for google docker registry
run: |
echo 'If this step fails, ensure that the main github action is done. We rely on it to get the docker images.'
git fetch --tags # this should have been done by the checkout action before.
make tag-cli-release-image RELEASE_IMAGE_TAG=v$RELEASE_IMAGE_VERSION
env:
RELEASE_IMAGE_VERSION: ${{ steps.new-semrel-version.outputs.version }}
- name: Re-tag service images with release version for github docker registry
run: |
make tag-release-images RELEASE_IMAGE_TAG=v$RELEASE_IMAGE_VERSION DOCKER_REGISTRY_URI=ghcr.io/freiheit-com/kuberpult
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ push-service-image/%: tag-service-image/%
docker push $(DOCKER_REGISTRY_URI)/$*:$(RELEASE_IMAGE_TAG)-datadog

.PHONY: tag-release-images
tag-release-images: $(foreach i,$(SERVICE_IMAGES),push-service-image/$i) tag-cli-release-image
tag-release-images: $(foreach i,$(SERVICE_IMAGES),push-service-image/$i)
sven-urbanski-freiheit-com marked this conversation as resolved.
Show resolved Hide resolved
true

# CLI is only stored in gcp docker registry
Expand Down
Loading