Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalendarColumnConverter: Fixed null handling and precision with DateT… #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

koduck
Copy link

@koduck koduck commented Jun 11, 2015

…ime values.

  • Null handling was broken.
  • using java.util.Date instead of java.sql.Date.
    java.sql.Date drops the Time and only stores the Date.

…ime values.

- Null handling was broken.

- using java.util.Date instead of java.sql.Date.
  java.sql.Date drops the Time and only stores the Date.
@kkalass
Copy link
Contributor

kkalass commented Jun 15, 2015

Die Aufgabe des Converters ist die Konvertierung von java.util.Date in den passenden SQL Datentypen. Über den SQL-Type wird gesteuert, ob es in einen sql.Timestamp oder in ein sql.Date konvertiert wird. Deine Änderung scheint mir erstmal nicht richtig zu sein. - der Nullness part aber natürlich schon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants